[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] Verbosity

From: Luca Bruno
Subject: Re: [Help-smalltalk] Verbosity
Date: Mon, 02 Oct 2006 08:31:31 +0200
User-agent: Opera Mail/9.01 (Win32)

In data 02 ottobre 2006 alle ore 07:37:36, Paolo Bonzini <address@hidden> ha scritto:

Luca Bruno wrote:
sorry if my patches are really small, this is the first time i'm reading the code ;)
No problem. It's the right way to start. Still, please configure your mailer to encode them as text/plain rather than application/octet-stream.
However this patch set verbosity > 2 for both Scavenging messages and readline symbols traceback on SIGINT, which are pretty boring.
The latter is wrong because in some cases (SIGSEGV) the backtrace is necessary. I'd prefer something like this:

I was looking at this:

case SIGINT:
      is_serious_error = false;
      if (!_gst_non_interactive && in_interpreter)
          _gst_set_signal_handler (sig, interrupt_handler);
          stop_executing ("userInterrupt");

Isn't ^C an user interruption?

      if (is_serious_error || sig == SIGUSR1
           || (_gst_verbosity > 2 && (ip || _gst_gc_running))

Can you confirm that it works?


Is important to show backtrace for SIGUSR1 anyway if verbosity is less than 3?

if (is_serious_error || (_gst_verbosity > 2 && (ip || _gst_gc_running))

-- - Thoughts about computer technologies

reply via email to

[Prev in Thread] Current Thread [Next in Thread]