[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Help-smalltalk] Re: [feature] make TwistedPools the default pool search

From: Stephen Compall
Subject: [Help-smalltalk] Re: [feature] make TwistedPools the default pool search order
Date: Mon, 21 Apr 2008 01:53:23 -0700

Issue status update for Post a follow up:

Project:      GNU Smalltalk
Version:      <none>
Component:    STInST
Category:     feature requests
Priority:     normal
Assigned to:  Unassigned
Reported by:  S11001001
Updated by:   S11001001
Status:       active

I added a fix for inherited class/shared pools and a test for it in
c097acd.  Also in c097acd is a new, failing test, fixed in b69098a, to
eliminate only the /direct superclass's/ namespaces from the namespace walk while searching pools. (See step #4 on

For the set of superspaces of this class and
all the superclasses' environments

While it is convenient, it doesn't match the expectation of step #4,
illustrated by the new test case, which is also why TwistedPools
originally used superclass environment withAllSuperspaces asSet to make
the sole set of namespace walk eliminations.

The unfortunate detail of this alternative, and thus a slight bug
introduced in b69098a, is that it may answer some namespaces multiple
times.  OrderedSet did the right thing, so I could ignore the issue,
but #allSharedPoolDictionariesDo: isn't necessarily building a set.  Of
course, the order is still right, so it doesn't affect a leftmost-first
variable search at all.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]