[Help-smalltalk] Fwd: PATCH1/2: byte code profiling for gst: recording

[Paolo Bonzini]

sent the review offlist by mistake

---------- Forwarded message ----------
From: Paolo Bonzini <address@hidden>
Date: Sun, Feb 8, 2009 at 23:29
Subject: Re: PATCH1/2: byte code profiling for gst: recording
To: Derek Zhou <address@hidden>


On Sun, Feb 8, 2009 at 21:08, Derek Zhou <address@hidden> wrote:
> Capture the raw profile in a data structure to be post-processed later. 
> Diffed against 3,1 git head from yesterday.
>
> diff --git a/kernel/CompiledBlk.st b/kernel/CompiledBlk.st
> index 96a2b8d..31dc219 100644
> --- a/kernel/CompiledBlk.st
> +++ b/kernel/CompiledBlk.st
> @@ -217,7 +217,7 @@ CompiledCode subclass: CompiledBlock [
>
>        <category: 'printing'>
>        aStream
> -           nextPutAll: '[] in ';
> +           nextPutAll: '[%1] in ' % {self hash};
>            print: method
>     ]

irrelevant?


> +    profilerOn [
> +       "Turn on the profiler"
> +
> +       <category: 'profiling'>
> +       <primitive: VMpr_SystemDictionary_profilerOn>
> +    ]

Can you pass the IdentityDictionary object here instead of creating it
in _gst_reset_profiler

> +  _gst_identity_dictionary_at_inc(profile, _gst_true_oop,
> +                                  _gst_bytecode_counter);
> +  _gst_bytecode_counter = 0;

Here can you save the bytecode counter and add the delta?

Otherwise ok.

Paolo