[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Help-smalltalk] Re: [PATCH 2/2] do not include categories in method bod

From: Paolo Bonzini
Subject: [Help-smalltalk] Re: [PATCH 2/2] do not include categories in method body
Date: Fri, 11 Sep 2009 09:58:22 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090814 Fedora/3.0-2.6.b3.fc11 Lightning/1.0pre Thunderbird/3.0b3

On 09/11/2009 09:03 AM, Tim Felgentreff wrote:
  packages/stinst/parser/ |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

this and th previous patch fix the two remaining problems I had with Squeak
format converting, namely wrong newlines and inclusion of the Gnu Smalltalk 
category in the method body.
Hope just posting them like this is ok.

Yes, it's fine.  I committed it to OldSyntaxExporter instead.

Can you check whether something like this is enough?

--- a/packages/stinst/parser/
+++ b/packages/stinst/parser/
@@ -44,9 +44,12 @@ OldSyntaxExporter subclass: SqueakSyntaxExporter [

     fileOutChunk: aString [
+        | s |
+        s := aString copyReplaceAll: '!' with: '!!'.
+        s := s replaceAll: Character nl with: Character cr.
-            nextPutAll: (aString copyReplaceAll: '!' with: '!!');
+            nextPutAll: s;
             nextPut: $!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]