[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH] STInST patches to allow converting PetitPar
Re: [Help-smalltalk] [PATCH] STInST patches to allow converting PetitParser/Magritte
Thu, 26 Aug 2010 16:36:52 +0200
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:126.96.36.199) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.0.5
On 08/26/2010 04:33 PM, Holger Hans Peter Freyther wrote:
as written in other threads. PetitParser is using binarySelectors that allow
more than two chars (allowed by Ansi Smalltalk) and we can not parse that, the
other is that Magritte/PetitParser use #classSide and STClassLoader didn't
know how to resolve that.
For the binary selector I have added a patch that allows to parse it when it
is coming from Squeak/Pharo and then we can rewrite it to => or such.
For the #classSide I have used Paolo's patch and propose it for inclusion. I
have not seen that the the STClassLoader allows to have dialect specific code
so I think it is best to include it. For the origin of #classSide, I have
clicked on versions in the Pharo browser and it appears to have a date from
2004, I don't know who added it though.
so please comment on the ChangeLog and code.
All looks good, thanks!
So now Magritte uses PP? :)