[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] smalltalk-mode typo

From: Denis Washington
Subject: Re: [Help-smalltalk] smalltalk-mode typo
Date: Mon, 10 Jan 2011 21:32:59 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101230 Lanikai/3.1.7

On 10.01.2011 20:58, Mathieu Suen wrote:
Hi Denis

On Jan 10, 2011, at 8:11 PM, Denis Washington wrote:


With today's git master, smalltalk-mode stopped working for me with Emacs 23 
(void-variable smalltalk-previous-keyword). After a little investigation, I 
found what seems to be a simple typo in today's changes to smalltalk-mode.el:

(defun* smalltalk-previous-keyword ...

(defun* smalltalk-next-keyword ...

Removing the '*' symbol from both function definitions removed the problem and 
makes smalltalk-mode work again from me. A patch is attached.
defun* is provided by cl so I suggest this instead:
diff --git a/smalltalk-mode.el b/smalltalk-mode.el
index fc2a587..7284900 100644
--- a/smalltalk-mode.el
+++ b/smalltalk-mode.el
@@ -25,6 +25,8 @@
  ;;; Incorporates Frank Caggiano's changes for Emacs 19.
  ;;; Updates and changes for Emacs 20 and 21 by David Forster

+(require 'cl)
  ;; ===[ Variables and constants ]=====================================

  (defvar smalltalk-name-regexp "[A-z][A-z0-9_]*"

You can fetch it from my repository:

Let me know if that fix the issue.

It does. So it's no typo after all... thanks for pointing this out.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]