[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] Patch for parsing dates and time

From: Maarten van Beek
Subject: Re: [Help-smalltalk] Patch for parsing dates and time
Date: Sun, 5 Aug 2012 02:29:00 +0200

Here's an updated version of the patch, I've removed unnecessary stuff from
this one.
dates-failing.ok and belong in the tests folder. I'm not
able to check my mail
until the 15th of august, so until then I won't be able to process any

Maarten van Beek

On Wed, Jul 25, 2012 at 1:20 AM, Maarten van Beek

> Here's the new patch, I removed the unused variables and added extra
> tests which consisting of the tests that are expected to fail.
> Maarten van Beek
> On Tue, Jul 24, 2012 at 11:16 AM, Holger Hans Peter Freyther
> <address@hidden> wrote:
> > On Mon, Jul 23, 2012 at 10:24:56PM +0200, Maarten van Beek wrote:
> >> The attached patch accepts negative dates and doesn't use position:
> >> anymore. I've removed the test cases that weren't possible to succeed
> >> because of this. This includes some test cases for DateTime, where
> >> DateTime skips over all separators to see if there's any usable
> >> content left. These separators are thrown away.
> >
> > Hi,
> >
> > in general it is good to test what can be parsed and what can not
> > be parsed. E.g. if someone wants to parse 09:00::1234 as 9:00 and
> > it fails it easy to point him to the testcase that excludes this
> > behavior, Pharo1.4 will throw an exception when parsing the above
> > string as a Time, I think it would be acceptable to do the same.
> >
> > Somehow I am not able to quote the attachment from within mutt but
> > you have some unused variables (e.g. you added 'pos' but don't make
> > use of it).
> >
> > For Paolo I have included the diff of expout to stdout when using
> > the right stream for parsing and then comparing what is left inside
> > the stream. Maarten's test results are already a lot better.
> >
> > holger
> >
> >
> > _______________________________________________
> > help-smalltalk mailing list
> > address@hidden
> >
> >

Attachment: dates4.patch
Description: Binary data

Attachment: dates-failing.ok
Description: Binary data

Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]