[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH] [RFC] dbd-sqlite: Do not fetch all rows of

From: Paolo Bonzini
Subject: Re: [Help-smalltalk] [PATCH] [RFC] dbd-sqlite: Do not fetch all rows of a select at once
Date: Mon, 26 Nov 2012 13:02:51 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

Il 20/11/2012 15:08, Holger Hans Peter Freyther ha scritto:
>      rowCount [
>          <category: 'accessing'>
>          self isSelect 
> -            ifTrue: [^self rows size]
> +            ifTrue: [^-1]

I think it's simpler to leave this method aside.  Code using
#next/#atEnd will simply not call #rowCount.

Otherwise the patch looks good, thanks!


>              ifFalse: [^self error: 'Not a SELECT statement.']
>      ]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]