[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH 0/3] rewrite parsing of literal arrays and f

From: Holger Hans Peter Freyther
Subject: Re: [Help-smalltalk] [PATCH 0/3] rewrite parsing of literal arrays and fix compilation of ##(...) within arrays
Date: Tue, 7 Jan 2014 22:43:17 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jan 07, 2014 at 12:35:54PM +0100, Paolo Bonzini wrote:

> Unfortunately, this change introduces a new kind of parse tree node,
> and thus requires modifying all visitors to support the new node.  This
> is a small backwards incompatibility.

Lovely! So it does work on '#(##(1/2) 3)' and I felt lucky to try to
import GNUplot now.

        heads := (#((' nohead' ' backhead') (' head') (' heads'))
                    at: (head ifTrue: [ 2 ] ifFalse: [ 1 ]))
                        at: (tail ifTrue: [ 2 ] ifFalse: [ 1 ]).

It fails with "each isOptimized" being DNU for the RBLiteralArrayNode.
I don't have a testcase yet but I think it breaks with a literl array
containing another one. :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]