[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH] Make Process>>queueInterrupt: thread safe

From: Holger Hans Peter Freyther
Subject: Re: [Help-smalltalk] [PATCH] Make Process>>queueInterrupt: thread safe
Date: Fri, 4 Apr 2014 10:50:50 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Sun, Mar 30, 2014 at 11:28:52PM +0200, Gwenaël Casaccio wrote:

Dear Gwenaël,

> The current implementation is not thread safe, when I'm
> inside Process>>queueInterrupt: the state of the process
> can change. I've added a simple guard to make it safer.

please put this and other context into the commit message. E.g.
how did you find the issue? Was it through review? Did something

The formatting before and after is quite odd in this method. It
is mixing tabs/spaces beyond the usual.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]