help-smalltalk
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] [PATCH v2 1/4] libgst: Fix comments


From: Holger Freyther
Subject: Re: [Help-smalltalk] [PATCH v2 1/4] libgst: Fix comments
Date: Sat, 2 Dec 2017 14:51:39 +0800

> On 30. Nov 2017, at 17:31, Lee Duhem <address@hidden> wrote:
> 

Hey!



> /* Grows the allocated memory to SPACESIZE bytes, if it's not there
> -   already.  
> -   the memory could not be allocated.  Should be called after the
> -   sweep has occurred so that things are contiguous.  Ensures that the
> -   OOP table pointers are fixed up to point to the new objects.  */
> +   already. */
> extern void _gst_grow_memory_to (size_t size) 

The "sweep" doesn't seem to be enforced (scavenge before as part of
the init_mem, but if invoked through the primitive I don't see a sweep).


Mentioning "_gst_fixup_object_pointers" and that no garbage is copied
might be valuable? I will most likely apply as is but why did you
decide to remove this?

cheers
        holger



reply via email to

[Prev in Thread] Current Thread [Next in Thread]