[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Help-smalltalk] small fixups to the tutorial

From: Holger Freyther
Subject: Re: [Help-smalltalk] small fixups to the tutorial
Date: Sat, 10 Mar 2018 06:21:42 +0000

> On 23. Jan 2018, at 20:02, Mathias Laurin <address@hidden> wrote:
> Hi list,


> Zecke told me that I should send my patches to the mailing list,
> so here I am.

sorry for the delay. The new day job took most of my time and energy.

> I am half through the online tutorial now and I would have a few
> more typos, formatting, stuttering, and whitespace fixes. I have
> grouped them in a single patch: `typos_and_whitespace.diff`.

great. I think one example is still wrong.

-   i := (Interval from: 5 to: 10 by: 2)
-   i do: [:x| x printNl]
+   i := Interval from: 5 to: 10 by: 2
+   i do: [:x | x printNl]

We need a "." after "Interval from..."?

> Also, the `Checking` class' `printOn:` message (section 6.6.2)
> prints the `'` marks. The changes in
> `improved_checking_printon.diff` use the `stream nextPutAll`
> already introduced in 6.4.5 for a better looking `printOn:`.

Not sure. Maybe the goal of the section was to show that instances
have a >>#printOn: method?

> Also, I think that it could be a good idea to remove the
> blank lines from the code examples, here is what I mean:

> because it would allow users to copy and paste the examples
> directly in a live interactive session. If you agree, I can make
> another patch.

Oh what happens with the parser and whitespace? What is the exception
you see? In general I would want to avoid whitespace only changes, they
make git blame more difficult to read/handle.

> Finally, I am not sure whether I should write to the Changelog
> or you do it... I have not done it.

Yes please. The best would be:

* Have a changelog entry and make a full git commit
* Use git send-email to send the patch to this list (so we can comment inline)

If you make more changes to the file I will need to ask you to make a
copyright assignment to the FSF.

have a nice day


reply via email to

[Prev in Thread] Current Thread [Next in Thread]