[zile-devel] [ zile-Patches-1821380 ] Correct 2 bugs in indentation

[SourceForge.net]

Patches item #1821380, was opened at 2007-10-27 15:11
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=317089&aid=1821380&group_id=17089

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: Yes
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Correct 2 bugs in indentation

Initial Comment:
I have send a mail to the mailing about this problem. As I had no feedback, I 
will send the patch as is. The patch corrects the two following bugs :

- The option 'tab-always-indent' does not seem to have the behaviour explained 
in the documentation. After testing a little, I have seen not difference (I may 
have missed something).

- If you are inserting spaces as tabs, you cannot undo a tab insertion in one 
operation (which is the case in emacs).

Cheers,

Julien (address@hidden)

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-10-27 17:48

Message:
Logged In: NO 

There was a part I was not really sure about so I removed it but after
testing the CVS version, it is needed. I have pasted the patch with this
reply.


Index: src/line.c
===================================================================
RCS file: /cvsroot/zile/zile/src/line.c,v
retrieving revision 1.74
diff -u -r1.74 line.c
--- src/line.c  27 Oct 2007 23:45:29 -0000      1.74
+++ src/line.c  28 Oct 2007 00:45:00 -0000
@@ -654,7 +654,9 @@
   Marker *save_point = point_marker();

   /* Find first non-blank char. */
+  FUNCALL(previous_line);
   FUNCALL(beginning_of_line);
+
   while (!eolp() && (isspace(following_char())))
     forward_char();



----------------------------------------------------------------------

Comment By: Reuben Thomas (rrt)
Date: 2007-10-27 16:53

Message:
Logged In: YES 
user_id=50145
Originator: NO

This patch looks good, thanks. I've applied it to CVS; could you possibly
test and confirm it works as you expect?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=317089&aid=1821380&group_id=17089