Re: Checking out files in the repository itself( how to better prevent )

[Derek R. Price]

Donald Sharp wrote:

> The current implementation prevents via the safe_location() function
> ( in checkout.c ).
>
> safe_location() follows symlinks back to find the actual location.  The
> problem that I am having is that repositories are not where they
> say they are due to mount issues.
>
> For Instance:
>
> One repository I have is at /nfs/swtrf/repository
> donsharp-u5:24> cd /nfs/swtrf/repository
> donsharp-u5:25> df -k .
> Filesystem            kbytes    used   avail capacity  Mounted on
> saba:/swtrf          8388608 3252424 4977952    40%    /auto/swtrf
> donsharp-u5:26> pwd
> /auto/swtrf/repository
> donsharp-u5:27>
>
> This causes the safe_location() check to not catch the fact that
> we really are inside of the repository.
>
> Would it be worthwhile to create a safer safe_location() that
> looks at mount points as well?

Sure.  Send me a patch.  Make sure to include a test case that will fail
with the current CVS and passes with the new one.  You can assume that the
test case is run in a directory it has write access to and which resides
on an NFS share.  Create the link in tmp and test from there...

Derek

--
Derek Price                      CVS Solutions Architect ( http://CVSHome.org )
mailto:address@hidden     OpenAvenue ( http://OpenAvenue.com )
--
Coffee is not for kids.
Coffee is not for kids.
Coffee is not for kids...

          - Bart Simpson on chalkboard, _The Simpsons_