info-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: commitinfo stopped working!


From: Tom Marsh
Subject: Re: commitinfo stopped working!
Date: Mon, 27 Oct 2003 17:24:23 -0500 (EST)

Mark:

Thanks for your quick reply! I probably mistated the problem somewhat. 
Using commitinfo in this way didn't stop anyone from adding bad 
directories, but it did stop them from adding files to those 
directories. But all that seems to have stopped working at all now. I 
don't even get the messages from my allowcommit.sh script when it 
accepts a file.

allowcommit.sh:

echo "==> Commit Accepted <=="
exit 0

denycommit.sh:

if [ "$2" = "readme.txt" ]; then
  exit 0
else 
  echo "==> Commit Denied for $2 <=="
  exit 1
fi


Tom

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Tom Marsh <address@hidden> writes:
> 
> > Dear info-cvs:
> > 
> > Help!
> > 
> > We're running cvs on HPUX, and built a good sized set of rules for 
> > directories in commitinfo. All our developer connections come in 
> > through pserver.
> > 
> > commitinfo is something like this:
> > 
> > CVSROOT     /usr/cvs/stuff/CVSROOT/allowcommit.sh
> > XXBLAH.*/install /usr/cvs/stuff/CVSROOT/allowcommit.sh
> > XXBLAH.*/reports /usr/cvs/stuff/CVSROOT/allowcommit.sh
> > DEFAULT     /usr/cvs/stuff/CVSROOT/denycommit.sh
> > 
> > We want to control the names of directories that get created. All 
of a 
> > sudden, it seems like commitinfo is getting ignored, as we're 
getting 
> > names of directories not specifically allowed by our commitinfo!
> > 
> > Does anyone have any ideas?
> 
> At present 'mkdir new-directory && cvs add new-directory' does not
> go thru the commitinfo code path. Instead, it creates the directory
> and then calls the loginfo trigger. The same basic thing happens if
> someone does a 'cvs import new-directory vendor version' in that the
> commitinfo script is not called.
> 
> A possible work around to your problem might be to have the loginfo
> trigger remove the offending directory in the repository and issue an
> error message.
> 
> There are also some patches from "Ralf S. Engelschall" that may 
already
> do what you want (he has a number of very useful extensions for
> importinfo too). They may be obtained via
> 
>   http://cvs.openpkg.org/openpkg-src/cvs/cvs.patch.rse
> 
> We are looking to incorporate some of these changes into the cvs TRUNK
> eventually, but none of them made it into the just release cvs 1.12.2
> release.
> 
>       Good luck,
>       -- Mark
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.3 (FreeBSD)
> 
> iD8DBQE/nYZ03x41pRYZE/gRArNtAJ9K5V309av5+GEniYH8aGtyoEFKewCgu6j7
> De9i6C6md7Mta3hn8yA7ml0=
> =I0KE
> -----END PGP SIGNATURE-----
> 
> 

-- 
NeoMail - Webmail that doesn't suck... as much.
http://www.neomail.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]