Re: message-signature-file toggled to nil locally

[Reiner Steib]

On Sun, Feb 03 2008, Sebastian P. Luque wrote:

> On Sun, 03 Feb 2008 18:12:57 +0100,
> Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>
>> On Sun, Feb 03 2008, Sebastian P. Luque wrote:
>>> I noticed that message-signature-file gets set to nil when composing
>>> messages, even though the signature is chosen correctly, based on
>>> gnus-posting-styles: [...]
>
>> So what is the problem?
>
> The problem is that if I want to change the signature, say through 'C-c
> C-w' (message-insert-signature), or gnus-personalities, then any
> reference to this variable doesn't do what's expected.

I see.  Does the following quite untested patch do the right thing?

--8<---------------cut here---------------start------------->8---
--- message.el  28 Jan 2008 09:02:57 -0000      7.239
+++ message.el  3 Feb 2008 18:49:59 -0000
@@ -3281,7 +3281,11 @@
 (defun message-insert-signature (&optional force)
   "Insert a signature.  See documentation for variable `message-signature'."
   (interactive (list 0))
-  (let* ((signature
+  (let* ((message-signature-file (or message-signature-file
+                                    (default-value 'message-signature-file)))
+        (message-signature (or message-signature
+                               (default-value 'message-signature)))
+        (signature
          (cond
           ((and (null message-signature)
                 (eq force 0))
--8<---------------cut here---------------end--------------->8---

Bye, Reiner.