[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RedHat/Fedora patches (Was: Re: [mtools] Mtools 3.9.10 for VMS)

From: Alain Knaff
Subject: Re: RedHat/Fedora patches (Was: Re: [mtools] Mtools 3.9.10 for VMS)
Date: Mon, 26 Jun 2006 13:10:51 +0200
User-agent: Thunderbird 1.5 (X11/20051201)

Moritz Barsnick wrote:

Alain wrote:
Moritz Barsnick wrote:
BTW, Fedora core 5 (and other Linux distributions?) has a bunch of
patches in the mtools code. Are they worth a look?
Judging from the version numbers, they look somewhat obsolete...

Well, they still apply them against the current version. They just
haven't re-built the patches.

ok. I looked at them, most of those 4 that you have attached seem still relevant and correct, with 1 exception:

e) mtools-3.9.9-noargs.patch
  - fixes case of missing arguments to scripts/mcomp, which is probably
    fair. IMO there could be more fixes in that script (like "" around
-> Should be used. Attached here.

While it's a good idea to do parameter checking and print a usage message, the usage message that they inserted is way of base...
It's a comparison script, so there really is not target or source.
Moreover, the way the script is written, there is no way to pass it mtools arguments (though I may fix that later on). And finally, if you pass multiple parameters to cmp, it compares those with each other, completely ignoring the DOS file input (read via mcopy).

So I replaced the usage message with one that actually makes sense.

I applied the other 3 patches as is.

The result is available as from the mtools site

I recommend that you check these attached patches and consider including
them. From what I can see, these four look valid. (They all apply fine
against your most recent 20060531 patch.)

Agreed (with exception of the noargs patch, as noted above)

I will try to follow up with my personal patches when I get around to
it. I have to check whether there was anything relevant there...

Please do. At that time, I may call a 3.9.11


mtools mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]