jacal-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Jacal-discuss] [PATCH] Fix some error reporting


From: Kris Katterjohn
Subject: [Jacal-discuss] [PATCH] Fix some error reporting
Date: Thu, 22 Dec 2022 13:28:54 -0500
User-agent: Mutt

Hi,

There are some bogus bltn:error calls related to coeffs, genmatrix,
integrate and transcript.  The symbols wna and not-a-polynomial?
intended for translations are not quoted.  I've attached a patch to
quote these.

e0 : coeffs([x]);

;ERROR: "builtin.scm": unbound variable:  not-a-polynomial?


e0 : integrate(x,x,0,1,2);
;loading anti-diff
;done loading anti-diff.scm

;ERROR: "anti-diff.scm": unbound variable:  wna


e0 : transcript(foo,bar);

;ERROR: "builtin.scm": unbound variable:  wna


It looks like the defbltn wna check for genmatrix prevents hitting the
problematic bltn:error call there.

I've also attached a separate patch to try to improve the defbltn wna
checks for integrate and transcript (or are you leaving off the upper
bound for a reason?).  I didn't remove the explicit check and bltn:error
call in the body of transcript because there are other places that still
have both defbltn and explicit checks and I wasn't sure whether or not
that was intentional.

Cheers,
Kris Katterjohn

Attachment: quote-symbols.patch
Description: Text document

Attachment: defbltn-wna-checks.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]