Re: [Jailkit-dev] Jailkit-2.20 patch to support Python3

[Olivier Sessink]

Hi Bill,

sorry it took so long, I finally had enough time to work trough
everything and test it. I did a full code review and testing on both
python2 and python3, and committed your patch to the repository. The
code was 100% OK, so many thanks for that.

One question: you removed netbasics from the openvpn section. Was that
required?

Olivier


On 04-06-19 22:50, William Stearns wrote:
> Good evening, Olivier,
>     I'm doing that testing now and have found even more that needs
> attention:
> - openvpn section had to "includesections" lines.
> - My configparser fix was incomplete.  So was my attempt at getting a
> portal octal constant.
> - File reads were coming in as bytes and need to be converted to strings
> on python3
> - The string.find/string.split/string.strip/string.join calls are
> deprecated and are replaced with {orig_string}.split() - type calls.
> - raw_input() is replaced with input()
> 
>     I've run each of the tools to make sure they'll at least
> successfully load and have built a chroot tree with jk_init , all with
> /usr/bin/python pointing at python3.5.  I've not tested any of this
> under python2.  Would someone with python2 be willing to do basic checks
> with this patch?
>     Cheers,
>     - Bill