[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/
From: |
R. Bernstein |
Subject: |
Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux |
Date: |
Mon, 27 Nov 2006 17:29:31 -0500 |
Many thanks.
I guess nothing based on /sys just yet.
Sorry for the late comment. I notice in cdio_follow_symlink() of
lib/driver/util.c some strcpy's used. Isn't good security practice to
use strncpy instead? Especially when one has the max length around
(PATH_MAX, and/or len)?
Again, thanks.
address@hidden writes:
> Hi,
>
> >> address@hidden writes:
> >> ...
> >> > - The function cdio_add_device_list() now adds drives, which come
> >> > under different names (i.e. as symlinks) only once.
> >> >
> >> > - A new function libcdio_follow_symlink() in util.c (moved from
> >> > gnu_linux.c, where I wrote it earlier).
> >> >
> >> > - Unrelated but trivial: The trailing "cvs" is removed from the
> >> > LIBCDIO_VERSION_NUM in the configure script to allow arithmetic
> >> > comparisons.
> >> >
> >> > It works pretty well here, but since it changes some major behaviour,
> >> > I to post it here before I apply it.
> >>
> >> I forgot to mention - I don't think there a problem with changing the
> >> behaviors listed above. (Of course if others do, they can speak for
> >> themselves.)
> >
> > Ok, I'll apply it in a couple of days if noone speaks up.
> >
>
> Done.
>
> Burkhard
>
>
>
> _______________________________________________
> Libcdio-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/libcdio-devel
>
- [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, plaum, 2006/11/20
- [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, R. Bernstein, 2006/11/20
- [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, R. Bernstein, 2006/11/20
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, plaum, 2006/11/21
- Message not available
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, plaum, 2006/11/27
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux,
R. Bernstein <=
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, Burkhard Plaum, 2006/11/28
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, R. Bernstein, 2006/11/28
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, Burkhard Plaum, 2006/11/28
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, R. Bernstein, 2006/11/28
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, Burkhard Plaum, 2006/11/28
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, Burkhard Plaum, 2006/11/28
- Re: [Libcdio-devel] [Patch] More bullet-proof drive detection for GNU/Linux, R. Bernstein, 2006/11/28