[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libcdio-devel] testpregap
From: |
R. Bernstein |
Subject: |
Re: [Libcdio-devel] testpregap |
Date: |
Mon, 9 Jun 2008 23:17:10 -0400 |
Robert William Fuller writes:
> Peter Creath wrote:
> > I just commited a fix for this bug. It was a structure packing issue.
>
> I did a cvs diff on nrg.h and it claimed no changes!
http://cvs.savannah.gnu.org/viewvc/libcdio/libcdio/lib/driver/image/nrg.h?hideattic=0&r1=1.6&r2=1.7&sortby=date
>
> > PowerPC likes to 4-byte align (and pad) structs, so _dao_common_t was
> > getting expanded to 24 bytes instead of 22. A carefully placed
> > GNUC_PACKED directive caused the test to pass.
> >
> > While I was at it, I fixed some compiler warnings in testpregap.c.in.
>
> Hmm ditto with this....
http://cvs.savannah.gnu.org/viewvc/libcdio/libcdio/test/testpregap.c.in?r1=1.1&r2=1.2&sortby=date