[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Libcdio-devel] 0.81 build trouble

From: Adrian Reber
Subject: [Libcdio-devel] 0.81 build trouble
Date: Tue, 30 Dec 2008 13:46:49 +0100
User-agent: Mutt/1.5.18 (2008-05-17)


I am maintaining the libcdio RPM for Fedora and while trying to update
to 0.81 I discovered an error which makes it impossible to build it.

The Fedora buildsystem is a minimal buildroot with no cdrom devices and
the build process goes into an endless loop because it cannot detect any
cdroms and when help2man tries to generate the manpages one of tools
(don't know which one anymore) does never end.

Following patch fixes it for me:

diff --git a/lib/driver/gnu_linux.c b/lib/driver/gnu_linux.c
index 7e2f3c4..092af0d 100644
--- a/lib/driver/gnu_linux.c
+++ b/lib/driver/gnu_linux.c
@@ -1448,7 +1448,7 @@ cdio_get_default_device_linux(void)
   /* Scan the system for CD-ROM drives.
      Not always 100% reliable, so use the USE_MNTENT code above first.
-  for ( i=0; checklist2[i].format; ++i ) {
+  for ( i=0; i < checklist2_size; ++i ) {
     unsigned int j;
     for ( j=checklist2[i].num_min; j<=checklist2[i].num_max; ++j ) {
       if (snprintf(drive, sizeof(drive), checklist2[i].format, j) < 0)

It seems this code part still looks for an empty element at the end of
the checklist2 array which does not exist anymore.

If there is not something really wrong with my patch I will apply it for
the Fedora libcdio 0.81 package.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]