[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libcdio-devel] [PATCH 0/2] fix various compilation warnings

From: Pete Batard
Subject: Re: [Libcdio-devel] [PATCH 0/2] fix various compilation warnings
Date: Mon, 13 Mar 2017 14:36:37 +0100
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

Hi Rocky,

On 2017.03.13 12:47, Rocky Bernstein wrote:
Cursory look is fine. Since you have access to the libcdio repository, a
suggestion is to create a git branch and apply these changes there. Then we
will merge that in.


You'll find that a new 'pbatard-fixes' branch has been pushed to libcdio.

If this is too onerous, I'll work from the patches, but attribution may
inadvertently get lost at has happened in the past.

I don't really mind for simple fixes like these, but yeah, it's nice to have proper attribution.

I've load track libcdio builds on MinGW?

libcdio still builds fine for MinGW, and, at least in my app, I haven't seen anything broken. But I'm only using a subset of libcdio there.

There's one test that fails though (realpath.exe, which produces a segfault) when running 'make test'. Maybe if I find time to spare, I'll try to take a look, but I can't promise anything.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]