[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libcdio-devel] a few small windows fixes

From: Ozkan Sezer
Subject: Re: [Libcdio-devel] a few small windows fixes
Date: Sat, 25 Nov 2017 15:55:16 +0300

On 11/25/17, Ozkan Sezer <address@hidden> wrote:
> See the attached three patches:
> #1: fix mixed declarations and code in win32_ioctl.c:
> lib/driver/MSWindows/win32_ioctl.c: In function
> 'audio_play_msf_win32ioctl':
> lib/driver/MSWindows/win32_ioctl.c:193:3: warning: ISO C90 forbids
> mixed declarations and code
> #2: fix 'strndup shadows a built-in function' warnings:
> if strndup() is not available, the build log is plagued with the
> following warnings:
> lib/driver/cdio_private.h:46:21: warning: declaration of 'strndup'
> shadows a built-in function
> So, rename the replacement inline strndup to libcdio_strdup, and
> define strndup as libcdio_strndup.
> #3: do not use sleep() for windows.
> _sleep() has long been deprecated and no longer prototyped in stdlib.h,
> despite the fact that msvcrt.dll still exports it. therefore, undefine
> HAVE_SLEEP when targeting windows, use Sleep win32 api function instead.

The list archive doesn't contain the attached patches. Some ridiculous
filter ate them??  Re-attaching them after renaming *.patch to *.txt,
maybe they arrive this time..


Attachment: 0001-fix-mixed-declarations-and-code-in-win32_ioctl.c.txt
Description: Text document

Attachment: 0002-fix-strndup-shadows-a-built-in-function-warnings.txt
Description: Text document

Attachment: 0003-do-not-use-sleep-for-windows.txt
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]