[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libcdio-devel] [RFC/PATCH] add multi extent ISO9660 file support to

From: Pete Batard
Subject: Re: [Libcdio-devel] [RFC/PATCH] add multi extent ISO9660 file support to libcdio
Date: Wed, 6 Jun 2018 22:23:21 +0100
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

Hi Thomas,

On 2018.06.06 19:13, Thomas Schmitt wrote:
- I'm not entirely sure that the sector size array is entirely necessary

The specs say that extents of the same file must be neighbors and in sequence.
But they do not outrule that an extent's size is not aligned to block size.
So there could be invalid bytes between extents.

Thanks for the clarification. I don't think having the sector size array hurts us much anyway, so if the specs allow for different sector sizes, we might as well handle it.

Then you will see on a filesystem that can store sparse files (here ext4):

That's a bit of a cheat... ;)

I looked into sparse files for NTFS, but that needs to be explicitly enabled with an Windows specific attribute during file creation, and I think people who are compiling libcdio on file systems that don't have sparse support will not be too happy if they have to create a 4GB file, especially if their file system is slow.

One option I see however would be to have a second level of tests, that could be invoked separately (e.g. 'make extra-test') and with a big warning alerting whoever runs them that they are likely to be disk or resource intensive.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]