[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Libcdio-devel] [RFC] Hid ISO_MAX_MULTIEXTENT from public and made e

From: Thomas Schmitt
Subject: Re: [Libcdio-devel] [RFC] Hid ISO_MAX_MULTIEXTENT from public and made extent list dynamic memory
Date: Mon, 02 Jul 2018 11:01:53 +0200


i wrote:
> > Further the previous programmers caused memory leaks with disposal of
> > iso9660_stat_t objects by free(3) rather than iso9660_stat_free().

Rocky Bernstein wrote:
> When you find errors like this please just fix them in the main branch.

I will first have to finish statv2 (and if it's only to demonstrate to
myself that it can be done).

Is there a way for dummies how to switch between git branches without
endangering uncommitted changes ?

> > In the current implementation this is problematic only with Rock Ridge
> > symbolic links.

Some of the sins might be harmless because at their position in the code
no Rock Ridge symlinks info would be recorded.
But i think this one is a valid bug:

The freed iso9660_stat_t *p_stat was completely created by
_iso9660_dir_to_statbuf(). So it may indeed have allocated memory at

Have a nice day :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]