Re: [Libcdio-devel] Merge request: branch trackno-higher-one : Added test about cdda_4_5.cue which checks for proper display of track start number > 1

[Rocky Bernstein]

Thanks for undertaking this. I'll look try out the code possibly over
the weekend, trying out make checkdist and make any administrative changes
in the unlikley even that this fails.

On Mon, Jan 14, 2019 at 6:35 AM Thomas Schmitt <address@hidden> wrote:

> Hi,
>
> sorry for being late with the promised test for track start number > 1.
>

No problem. Thanks for adding the test.


>
> I now prepared the changeset sketched in my mail of
>   Sun, 30 Dec 2018 11:47:22 +0100
>
> The files test/Makefile.in and test/data/Makefile.in do not get removed
> by "make clean". So in order to see the effect of the changes in the
> Makefile.am files, one has to remove the Makefile.in files manually before
> running "make clean ; ./configure ; make".
> I did not test whether "make dist" includes the files. But the Makefiles
> now have them in their intended check_DATA lists.
>
> I include my local copy of src/cd-info.c which is supposed to already
> be commited to master by Edd Barrett's efforts. (Without that change the
> now extended test check_cue.sh rightously reports FAIL.)
>
> In test/data/Makefile.am there was a doule mentioning of cdda.bin.
> I replaced the surplus one by my new file names.
>
> ---------------------------------------------------------------------------
>
> $ git commit -m 'Added test about cdda_4_5.cue which checks for proper
> display of track start number > 1'
> [trackno-higher-one 30c1609] Added test about cdda_4_5.cue which checks
> for proper display of track start number > 1
>  6 files changed, 47 insertions(+), 15 deletions(-)
>  create mode 100644 test/cdda_4_5.right
>  create mode 100644 test/data/cdda_4_5.cue
>
> $ git push
> Counting objects: 10, done.
> Delta compression using up to 8 threads.
> Compressing objects: 100% (10/10), done.
> Writing objects: 100% (10/10), 1.33 KiB | 0 bytes/s, done.
> Total 10 (delta 7), reused 0 (delta 0)
> To address@hidden:/srv/git/libcdio.git
>    48aaef9..30c1609  trackno-higher-one -> trackno-higher-one
>
> See:
>
> http://git.savannah.gnu.org/cgit/libcdio.git/commit/?h=trackno-higher-one&id=30c1609277d83af714ce312850d36ac48ccebc41
>
>
> Have a nice day :)
>
> Thomas
>
>
>