Re: [Libcdio-devel] Merge request: branch trackno-higher-one : Added test about cdda_4_5.cue which checks for proper display of track start number > 1

[Thomas Schmitt]

Hi,

Rocky Bernstein wrote:
> trying out make checkdist and make any administrative changes
> in the unlikley even that this fails.

Hmm ... yes. One piece was missing. New commit

  "Added cdda_4_5.bin and cdtextfile.bin to the exemption list of 
test/check_fuzzyiso.sh"
  
http://git.savannah.gnu.org/cgit/libcdio.git/commit/?h=trackno-higher-one&id=0d08612f3a550a1faa48937a3a0254b3dff02b3d


Reasoning:

I did "make check" with and without my change to src/cd-info.c.
It reported "PASS: bincue" or "FAIL: bincue" respectively. I did not
look for other failures, though.
i
Obviously expected is "XFAIL: testassert" but then there is

  FAIL: check_fuzzyiso.sh

The message in test/test-suite.log says
------------------------------------------------------------------------
FAIL: check_fuzzyiso.sh
=======================

-- Sorry, could not find an ISO 9660 image from 
/u/stacker/libcdio_dir/libcdio.rocky/test/data/cdda.bin
-- Sorry, could not find an ISO 9660 image from 
/u/stacker/libcdio_dir/libcdio.rocky/test/data/cdda_4_5.bin
./check_fuzzyiso.sh: failed running:
        /u/stacker/libcdio_dir/libcdio.rocky/test/../example/isofuzzy 
/u/stacker/libcdio_dir/libcdio.rocky/test/data/cdda_4_5.bin

------------------------------------------------------------------------

And yes, in the script i see a list of exemptions, where ccd.bin is member:

  case "$file" in
  $src_dir/data/p1.nrg | $src_dir/data/p1.bin | $src_dir/data/cdda.bin | 
$src_dir/data/cdda-mcn.nrg | $src_dir/data/svcdgs.nrg | 
$src_dir/data/cdtext.bin | $src_dir/data/udf102.iso )
    good_rc=1

Ok, i add cdda_4_5.bin but still get FAIL. This time because of:

  /check_fuzzyiso.sh: failed running:
        /u/stacker/libcdio_dir/libcdio.rocky/test/../example/isofuzzy 
/u/stacker/libcdio_dir/libcdio.rocky/test/data/cdtextfile.bin

Now with

  ... | $src_dir/data/cdda_4_5.bin | $src_dir/data/cdtextfile.bin ...

it passes.
There is no check_fuzzyiso.sh.in. So i commit the script directly.


Have a nice day :)

Thomas