Re: [Libcdio-devel] Rock Ridge deep directory support

[Pete Batard]

Hi Rocky,

On 2020.06.17 20:08, Rocky Bernstein wrote:
> Thanks for doing the work and for merging.
>
> I just ran "make distcheck" (building outside of source directory from a
> tarball) and I get a couple of failures:
>
> ...
> FAIL: check_multiextent.sh
> PASS: check_fuzzyiso.sh
> PASS: check_opts.sh
> FAIL: check_deep_directory.sh

I'm pretty sure this is because we don't have a .in to generate the .sh 
and set srcdir and top_builddir to an absolute path, as is done in other 
tests.

I considered doing it, but then I found that check_fuzzyiso.sh wasn't, 
and since I didn't see errors from using relative paths during my 
testing, I thought we would be fine.

I'll look into generating the .sh from a .sh.in when I get a chance.

>  From check_deep_directory.sh.log:
>
> -- ../../../test/check_deep_directory.sh: Deep directory listing test ok.
> /usr/bin/diff: ../../../test/data/deep_directory1_file: No such file or
> directory
> ../../../test/check_deep_directory.sh: Deep directory read test level 8
> failed.
> ../../../test/check_deep_directory.sh: failed command:
> ../src/iso-info ../src/iso-read --ignore --image
> ../../../test/data/deep-directory.iso --extract 1/2/3/4/5/6/7/8/8.txt
> FAIL check_deep_directory.sh (exit status: 3)
>
> And from check_multiextent.sh.sh:
>
> -- ../../../test/check_multiextent.sh: Multiextent listing test ok.
> /usr/bin/diff: ../../../test/data/multi_extent_file: No such file or
> directory
> ../../../test/check_multiextent.sh: Multiextent read test failed.
> ../../../test/check_multiextent.sh: failed command:
> ../src/iso-info ../src/iso-read --ignore --image
> ../../../test/data/multi_extent_8k.iso --extract multi_extent_file
> FAIL check_multiextent.sh (exit status: 3)
>
> I think those new files mentioned need to be added to the check_DATA variable
> test/data/Makefile.am.

They are already there.

Regards,

/Pete