[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libmicrohttpd] [PATCH] Avoid silent misbehaviour on pthread join fa
|
From: |
Christian Grothoff |
|
Subject: |
Re: [libmicrohttpd] [PATCH] Avoid silent misbehaviour on pthread join failure |
|
Date: |
Sat, 10 Oct 2009 13:42:22 +0200 |
|
User-agent: |
KMail/1.11.2 (Linux/2.6.27-14-generic; KDE/4.2.2; i686; ; ) |
No need, I'll change it to only check the return value of pthread_join. -
Christian
On Friday 09 October 2009 04:22:10 pm Mike Crowe wrote:
> On Fri, Oct 09, 2009 at 03:24:48PM +0200, Christian Grothoff wrote:
> > Makes sense. I've fixed this in SVN HEAD, but with a slightly more
> > verbose report in case that --enable-messages was given to configure.
>
> Thanks.
>
> Actually it turns out that I hadn't adequately tested my patch.
> pthread_kill returns ESRCH when called on a terminated but not yet
> joined thread.
>
> It would seem that either ignoring the return value of pthread_kill as
> before or explicitly allowing ESRCH would be a better solution.
>
> Oddly 'make check' didn't seem to spot this. :(
>
> I can prepare a fixed patch based on SVN HEAD if you'd like me to.
>
> Sorry.
>
> Mike.