Re: [libmicrohttpd] MHD_destroy_post_processor() is unsafe

[Andreas Wehrmann]

On 11/24/2011 03:01 PM, Christian Grothoff wrote:
> Well, if creating the PP failed, why would you try to destroy it? ;-).
>
> I don't think that any function has to work nicely when being called 
> with NULL (unless specified that it should accept NULL, of course).
>
> Happy hacking,
>
> Christian

That's easy: Because I continued to handle the request although creating 
th PP failed...
Yes I know, my mistake :-)

But then:
Why do you check whether PP is not NULL in MHD_post_process()?
Same problem there.

It may be confusing to some users that some functions are "safe" and 
some are not,
I think the library should be clear on this.


Regards,

Andreas

--
Dipl.-Ing. (FH) Andreas Wehrmann
Software Development
--------------------------------------------------------------
Center Communication Systems GmbH
A-1210 Wien, Ignaz-Köck-Straße 19
Sitz in Wien
FN 796 88p, Firmenbuchgericht Wien
www.centersystems.com

Tel.: +43 (0) 190 199 - 3616
Mobile: +43 (0) 664 884 75916
Fax: +43 (0) 190 199 - 2110
E-Mail: address@hidden