Re: [libmicrohttpd] Bug in largepost.c example

[Christian Grothoff]

Hi Anton,

I've "fixed" this in SVN 36758, even though I think this is the last
thing to be concerned about (as others have explained, this really does
not matter).

Looking over the example, it is clear that it could use quite a bit of
work (starting with adding comments...) to make it nicer.  I've started
a bit by introducing an "enum" for GET/POST and properly using MHD
#defines for "GET" and "POST" strings (and using strcasecmp instead of
strcmp).

So regardless, please treat all of these examples as starting points
that try to highlight at a very high level how to do something specific,
and not as overall beautiful code. There is more work there to be
done... ;-).

Happy hacking!

Christian

On 12/11/2015 08:51 AM, Anton Botvalde wrote:
> Hello,
> 
> In the largepost.c example the iterate_post callback has a bug in fwrite -
>   if (size > 0)
>     {
>       if (!fwrite (data, size, sizeof (char), con_info->fp))
>         return MHD_NO;
>     }
> 
> should be
> 
>   if (size > 0)
>     {
>       if (!fwrite (data, sizeof (char), size , con_info->fp))
>         return MHD_NO;
>     }
> 
> Kind regards,
> Anton Botvalde
>

signature.asc
Description: OpenPGP digital signature