[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libmicrohttpd] [PATCH] epoll: add locking around eready DLL
|
From: |
Christian Grothoff |
|
Subject: |
Re: [libmicrohttpd] [PATCH] epoll: add locking around eready DLL |
|
Date: |
Tue, 15 Mar 2016 19:09:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 |
Well, that's debatable, as it's really cheap and might aid with
diagnostics. I can see this one go either way, IIRC I left it in as it
is now thinking that preserving the invariant was a good thing. But as I
said, I have no particularly strong feelings here.
On 03/15/2016 06:32 PM, Dan Dedrick wrote:
> Somewhat related it's probably worth putting the whole epoll switch
> statement in connection.c under an "if (0 != (daemon->options &
> MHD_USE_EPOLL_LINUX_ONLY))" because there is no point in adding the
> connection to the epoll linked list or updating the epoll_state when we are
> not running in epoll mode.
>
> Dan
signature.asc
Description: OpenPGP digital signature