libmicrohttpd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libmicrohttpd] Typo?: MHD_SUPPRESS_DATE_NO_CLOCK and MHD_NO_FLAG


From: silvioprog
Subject: Re: [libmicrohttpd] Typo?: MHD_SUPPRESS_DATE_NO_CLOCK and MHD_NO_FLAG
Date: Mon, 30 Jan 2017 15:36:23 -0300

It's a little bit strange to have too suffixed flags keeping only two unsuffixed, unless removing suffix of all other flags. :-/

But suffix is very helpful when we are using many flags, because suffix help us to know what feature a flag belongs to, so it would be nice if we could rename it to MHD_USE_SUPPRESSED_DATE ("use suppressed date" makes sense) and MHD_USE_END_FLAG ("use end flag" makes sense too).

I had a problem in my project, it didn't compile it because a flag was renamed, luckily I checked the GIT log and found some flags renamed, so a major version should be released warning these last changes was done in the MHD interface.

On Sun, Jan 29, 2017 at 8:00 PM, Christian Grothoff <address@hidden> wrote:
Well, it was discussed (between Evgeny and me), and "USE_" together with
"SUPPRESS" or "NO" made no sense linguistically, so we decided to not
rename these flags, also to minimize disruptions.

On 01/29/2017 10:35 PM, silvioprog wrote:
> Hello masters,
>
> I've noticed all flags for `USE` scope was prefixed with `MHD_USE_*`,
> except these two flags. So, it was a typo or is that OK?
> Anyway MHD_USE_SUPPRESS_DATE and MHD_USE_NO_FLAG makes more sense,
> following the same other FLAGs pattern.
>
> Thanks!

--
Silvio Clécio

reply via email to

[Prev in Thread] Current Thread [Next in Thread]