libmicrohttpd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libmicrohttpd] FreeBSD tests failing


From: Christian Grothoff
Subject: Re: [libmicrohttpd] FreeBSD tests failing
Date: Wed, 1 Feb 2017 00:12:15 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0

Yep, configure.ac had the wrong setting for FreeBSD, falsely claiming
that shutdown() "worked" to unblock a listen socket in epoll/select.
Fixed in Git:

diff --git a/configure.ac b/configure.ac
index d9316ab6..8094d520 100644
--- a/configure.ac
+++ b/configure.ac
@@ -246,7 +246,7 @@ freebsd*)
      AC_DEFINE_UNQUOTED(SOMEBSD,1,[This is a BSD system])
      AC_DEFINE_UNQUOTED(FREEBSD,1,[This is a FreeBSD system])
      mhd_host_os='FreeBSD'
-     shutdown_trig_select='yes'
+     shutdown_trig_select='no'
      AC_MSG_RESULT([[$mhd_host_os]])
      ;;
 openbsd*)


On 02/01/2017 12:04 AM, Christian Grothoff wrote:
> Hi Mate,
> 
> Well, I knew that 'shutdown' behaves different on FreeBSD than on Linux,
> and at least some time ago we carefully avoided the use of the
> Linux-specific shutdown semantics on FreeBSD.  Now, it seems that
> somehow we have a regression in that regards, at least with respect to
> the testcases (which likely points to an issue in the main code, as a
> test should obviously not be able to trigger the problem).
> 
> I'll look into it.
> 
> -Christian
> 
> On 01/31/2017 11:10 PM, Börcsök Máté wrote:
>> Dear maintainers,
>>
>> I wanted to do some tests on FreeBSD, so I created a machine on a
>> mainstream cloud service with these parameters:
>> 2 GB Memory, 2 cores, FreeBSD 11.0 zfs
>>
>> I cloned the git repository, downloaded the necessary packages and compiled
>> with clang.
>> latest commit c623d35dcc88d0e90a239289b947f0199ad02d5b
>> Date:   Sun Jan 22 23:24:24 2017 +0300
>>
>> make check had strange results, test_shutdown_select and test_shutdown_poll
>> were failing.
>> I did some investigation and added a new trace in the test code, see
>> attached diff file.
>>
>> Any ideas? Is it a microhttpd or FreeBSD problem?
>>
>> Cheers,
>> Mate
>>
> 

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]