[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libredwg] typedefs

From: Rodrigo Rodrigues da Silva
Subject: Re: [libredwg] typedefs
Date: Wed, 29 Dec 2010 02:07:59 -0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101208 Thunderbird/3.1.7

On 28-12-2010 16:44, Felipe Sanches wrote:
> I dont like it, but I wont block your work.
> Keep in mind that typing speed can be improved with copy&paste
> And we should avoid making the code less readable for the newcomer
> hackers. Everybody who looks at unsigned int knows what it is. If you
> see "LdUInt32" you have to stop and think for a while.
> anyway... if you really want to use a prefix, Ld does not sound like a
> mnemonic for libredwg. Before reading your explanation I was thinking
> of "Ld" as "load" even if it makes no sense... If you're going to use
> a prefix, make it more explicit.

I agree with Felipe.

Maybe we should check what the GNU Coding Standards say on that.
Besides, we already have other typedefs that we should review.

> On Mon, Dec 27, 2010 at 1:58 PM, Till Heuschmann
> <address@hidden> wrote:
>> Can I create some typedefs for the basic types such as:
>> typedef int           LdInt32;
>> typedef unsigned int  LdUInt32;
>> typedef int64_t       LdInt64;
>> typedef u_int64_t     LdUInt64;
>> ...
>> At the moment the types (32/64 bit) are heavily mixed and It's a pain to
>> write "long unsigned int" all the time.
>> As one might expect the "Ld" stands for LibreDWG!!
>> I do not know if these typedefs can be automatically set by the build stage?

Rodrigo Rodrigues da Silva

Attachment: 0xE67BD84E.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]