[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libredwg] Patch homework

From: Pero Brbora
Subject: Re: [libredwg] Patch homework
Date: Wed, 25 Mar 2015 18:28:11 +0100
User-agent: Internet Messaging Program (IMP) H4 (5.0.23)

I have created few more patches.

First one is for src/api.c - unusual coding standard which doesn't return value on error from functions which are supposed to return some value - fixed.

Second one if for unit-testing/common.c - prevent using dwg_free() on error, which probably caused segfaults when doing make check - fixed.

Also I used make -k check (make option to keep going even on error) which resulted with the folowing test results:

UNIT TESTING: 40 of 40 tests failed

EXAMPLES: 1 of 1 test failed (permission denied to run ./alive.test)


# of expected passes            339
# of unexpected failures        17

Note: Lots of "warning: assignment makes pointer from integer without a cast". Macros are evil.


Attachment: 0001-Return-some-value-on-error-from-functions-returning-.patch
Description: Text Data

Attachment: 0002-Prevent-segfault-on-error.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]