libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: duplicate removal patch [Was Re: ok, new libtool for cygwin upd


From: Gary V . Vaughan
Subject: Re: FYI: duplicate removal patch [Was Re: ok, new libtool for cygwin updates]
Date: Sun, 1 Apr 2001 12:50:21 +0100

On Sunday 01 April 2001 11:50 am, Michael Matz wrote:
> Hi,
>
> On Sun, 1 Apr 2001, Gary V. Vaughan wrote:
> > > >> Not really.  We really must fix the bug that causes us to remove
> > > >> duplicate libraries before releasing 1.4.
> > > >
> > > > Huh?  Seems like I'm missing something here.  What is this bug
> > > > exactly?
> > >
> > > There is this chunk of code that removes duplicate `-l' flags that
> > > appear in a link command.  The order of `-l' flags is relevant; we
> > > tell whether it's safe to remove -l flags from the beginning or from
> > > the end without looking into all other libraries.  So we shouldn't do
> > > it.
> >
> > I have applied the following to HEAD (and similar to MLB).
>
> Why also MLB?  Was it really broken there too?  I ask, because I
> _definitely_ got multiple libraries in link commands.

Try out the new depdemo-dups.test on an old libtool script, and you'll see 
what I mean.  Perhaps I have found and fixed a similar but different bug?

This patch prevents removal of duplicate deplibs; in the test script it tries 
to link depdemo/l1/libl1.la and depdemo/l2/libl2.la into an executable.  
Before the patch, the libl2 deplib `libl1.la' was removed from the link 
command because it was also specified explicitly.

Both HEAD and MLB correctly handled `.. -la -lb -la' already.  Is there some 
other situation where duplicates are removed erroneously that I missed?

> Ciao,
> Michael.

Cheers,
        Gary.
-- 
  ___              _   ___   __              _         mailto: address@hidden
 / __|__ _ _ ___ _| | / / | / /_ _ _  _ __ _| |_  __ _ ___       address@hidden
| (_ / _` | '_|// / |/ /| |/ / _` | || / _` | ' \/ _` | _ \
 \___\__,_|_|\_, /|___(_)___/\__,_|\_,_\__, |_||_\__,_|//_/
home page:  /___/                      /___/                  gpg public key:
http://www.oranda.demon.co.uk           http://www.oranda.demon.co.uk/key.asc



reply via email to

[Prev in Thread] Current Thread [Next in Thread]