[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

(no subject)

From: Bob Friesenhahn
Subject: (no subject)
Date: Wed, 31 Mar 2004 11:11:54 -0600 (CST)

On Wed, 31 Mar 2004, Gary V. Vaughan wrote:

> Hash: SHA1
> Okay to commit?
> This addresses the memory management problems in libltdl brought
> to light by the kaffe people.

The style of this change confuses me, and it doesn't seem to do
exactly the same thing:

   /* If ARGZ_LEN has shrunk to nothing, release ARGZ's memory.  */
   if (!argz_len)
-    LT_DLFREE (argz);
+    argz = (free (argz), (char *) 0);

The change of lt_ functions to 'x' versions (e.g. xmalloc)
implies that it is intended that these functions be moved out of
ltdl.c and into another source module.  If so, the 'x' versions may
then conflict with other 'x' versions used by the dependent program.
It seems better to retain the lt_ prefix because then the origin of
the functions is more clear and there is no danger of conflict.

Bob Friesenhahn

reply via email to

[Prev in Thread] Current Thread [Next in Thread]