[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: HEAD: minor m4 quoting issue

From: Noah Misch
Subject: Re: HEAD: minor m4 quoting issue
Date: Thu, 25 Aug 2005 11:37:57 -0700
User-agent: Mutt/1.5.6i

On Thu, Aug 25, 2005 at 03:01:29PM +0200, Ralf Wildenhues wrote:
>         * libltdl/m4/libtool.m4 (_LT_SYS_DYNAMIC_LINKER)
>         (_LT_LINKER_SHLIBS): Double-quote unsafe tag variable
>         descriptions: they are literals.

This is reasonable.  The central problem is _LT_LIBTOOL_DECLARE expanding
variable descriptions in m4_quote.  Since you must eventually let a string
function consider the expanded text, this may be impossible to fix[1].

Practically every use of m4_quote is a data-dependent bug waiting to happen.  It
squashes whitespace around commas, and unmatched parentheses yield M4 parse
errors.  That said, changing `m4_quote($1)' to `[$1]' where both work for most
inputs only changes the classes of data that produce misbehavior.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]