Re: Fix LT_WITH_LTDL: AU_ALIAS bug

[Gary V. Vaughan]

Hallo Ralf,

Ralf Wildenhues wrote:
> Hunting down bugs in m4 macros sucks.  Using $# in macros sucks, too.

:-(  Can you document in HACKING that because of our use of AU_ALIAS to
maintain backwards compatibility with earlier libtool interfaces we must
not use $# in m4.

Also, we could do with an m4.test to catch violations of our m4 style
guidelines -- much as we have sh.test to catch shell style violations.
Can you add a TODO item for that too please?

> First: LT_WITH_LTDL needs to be documented correctly.  Its predecessor
> AC_WITH_LTDL needed documentation as well.  I accept patches.  :)

I've been working on this for almost 2 weeks now.  The whole thing is
almost hopelessly broken.  Now that I've started using quilt I'll start
posting the patches in small bits as soon as I have the damn thing
working.

> Anyway, I consider testing against $# error-prone, and bad for forward
> compatibility anyway (when the possible number of arguments could be
> greater than one),

ACK.

> so I would like to apply this patch, which uses
> m4_default instead.  OK for HEAD?

Okay.

>         * libltdl/m4/ltdl.m4 (LT_WITH_LTDL, LTDL_CONVENIENCE)
>         (LTDL_INSTALLABLE): Use m4_default instead of m4_if, to cope
>         with empty macro arguments.  Use less quoting for expanded
>         LIBLTDL, LTDLINCL

Cheers,
        Gary
-- 
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

signature.asc
Description: OpenPGP digital signature