[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FYI: fix dumpbin symbol pipe
From: |
Ralf Wildenhues |
Subject: |
Re: FYI: fix dumpbin symbol pipe |
Date: |
Fri, 23 Sep 2005 12:13:53 +0200 |
User-agent: |
Mutt/1.4.1i |
Hi Peter,
* Peter Ekberg wrote on Fri, Sep 23, 2005 at 11:27:05AM CEST:
> Ralf Wildenhues wrote on Thursday, September 22, 2005 16:41 CEST:
> > * Peter Ekberg wrote on Thu, Sep 22, 2005 at 04:24:16PM CEST:
> > > * Ralf Wildenhues wrote on Thursday, September 08, 2005 11:23
> > Dan added multiline *output variable* support to CVS Autoconf, but
> > not multiline *cache variable*. So, in fact, we are misusing
> > caching here; it's documented not to allow newlines. Sorry for not
> > clearing that up back then.
>
> No problem, I'm not using caching much (yet) and I don't expect others
> are using dumpbin (yet) so...
OK.
> > Would you like to fix it? You could either rewrite your first real
> > awk script to consist of one line only, or add a helper variable to
> > remember to unset lt_cv_sys_global_symbol_pipe after the
> > AC_CACHE_CHECK, I guess. (Please don't break caching for everyone
> > else, it's a rather expensive check.)
> >
> > > Or are the autoconf people tuned in to this station?
> >
> > I would've guessed they'd chime in (and correct me ;-).
Just to clear this up: I did not mean I'd _expect_ anyone to to this.
I did plan on eventually finishing this (and I do report Autoconf bugs
on their lists, and not elsewhere), you just beat me to it. ;)
> Here's a patch:
>
> * libltdl/m4/libtool.m4 (_LT_CMD_GLOBAL_SYMBOLS): Fix awk script
> to be a single line so that the cache variable isn't multiline.
Good, please apply! (Will look rather ugly for the user, but looks are
clearly second winners here.)
Thanks,
Ralf