Re: 281-gary-fixup-ltdl-symbolnames.diff

[Bob Friesenhahn]

On Tue, 27 Sep 2005, Gary V. Vaughan wrote:

> Okay to apply to HEAD?

This patch looks good.  It does not appear to have a de-stabilizing 
effect.

Bob

> Symbol naming convention nit.
>
> libltdl/lt_error.c |   14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> Index: libtool--devo--1.0/ChangeLog
> from  Gary V. Vaughan  <address@hidden>
>         * libltdl/lt_error.c (lt__last_error, lt__error_strings): The lt__
>         prefix is used to indicate internal symbols that are only exported
>         for use by other parts of libltdl.  These are now static, so...
>         (last_error, error_strings): ...renamed to this.  Changed all
>         callers.
>
> Index: libtool--devo--1.0/libltdl/lt_error.c
> ===================================================================
> --- libtool--devo--1.0.orig/libltdl/lt_error.c
> +++ libtool--devo--1.0/libltdl/lt_error.c
> @@ -1,5 +1,5 @@
> /* lt_error.c -- error propogation interface
> -   Copyright (C) 1999, 2000, 2001, 2004 Free Software Foundation, Inc.
> +   Copyright (C) 1999, 2000, 2001, 2004, 2005 Free Software Foundation, Inc.
>    Originally by Thomas Tanner <address@hidden>
>
>    NOTE: The canonical source of this file is maintained with the
> @@ -29,8 +29,8 @@ Software Foundation, Inc., 51 Franklin S
> #include "lt_error.h"
> #include "lt__private.h"
>
> -static const char      *lt__last_error = 0;
> -static const char      lt__error_strings[LT_ERROR_MAX][LT_ERROR_LEN_MAX + 1] =
> +static const char      *last_error     = 0;
> +static const char      error_strings[LT_ERROR_MAX][LT_ERROR_LEN_MAX + 1] =
>   {
> #define LT_ERROR(name, diagnostic)      (diagnostic),
>     lt_dlerror_table
> @@ -75,7 +75,7 @@ lt_dlseterror (int errindex)
>   else if (errindex < LT_ERROR_MAX)
>     {
>       /* No error setting the error message! */
> -      LT__SETERRORSTR (lt__error_strings[errindex]);
> +      LT__SETERRORSTR (error_strings[errindex]);
>     }
>   else
>     {
> @@ -92,17 +92,17 @@ lt__error_string (int errorcode)
>   assert (errorcode >= 0);
>   assert (errorcode < LT_ERROR_MAX);
>
> -  return lt__error_strings[errorcode];
> +  return error_strings[errorcode];
> }
>
> const char *
> lt__get_last_error (void)
> {
> -  return lt__last_error;
> +  return last_error;
> }
>
> const char *
> lt__set_last_error (const char *errormsg)
> {
> -  return lt__last_error = errormsg;
> +  return last_error = errormsg;
> }
> --
> Gary V. Vaughan      ())_.  address@hidden,gnu.org}
> Research Scientist   ( '/   http://tkd.kicks-ass.net
> GNU Hacker           / )=   http://www.gnu.org/software/libtool
> Technical Author   `(_~)_   http://sources.redhat.com/autobook

======================================
Bob Friesenhahn
address@hidden, http://www.simplesystems.org/users/bfriesen/
GraphicsMagick Maintainer,    http://www.GraphicsMagick.org/