Re: FYI: centralise INCLTDL [291]

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Tue, Oct 11, 2005 at 12:29:26AM CEST:
> Ralf Wildenhues wrote:
> > * Gary V. Vaughan wrote on Mon, Oct 10, 2005 at 07:21:39PM CEST:
> > 
> >>Applied to HEAD.
> > 
> > Gah, it breaks mdemo. mdemo/configure.ac does not invoke LT_WITH_LTDL
> > _at all_.  Looking at branch-1-5, I guess we have to support this
> > mode, too.  :-/
> > 
> > Can you look into fixing this?
> 
> No need.  *everything* passes when all my patches are applied.  It's
> only because we're tackling them out of order that the tree is a little
> inconsistent right now.  Feel free to back it out, and I'll reapply
> later when the other patches go in...
> 
> If you have a particular host that fails with the whole stack applied on
> the other hand, I'd like to fix that...

Fails also mdemo-make tests with all patches applied in order
(GNU/Linux, bootstrapped with 2.59/1.9.2, no libobj patches applied):

[...]
| gcc -DPACKAGE_NAME=\"mdemo\" -DPACKAGE_TARNAME=\"mdemo\" 
-DPACKAGE_VERSION=\"1.0\" -DPACKAGE_STRING=\"mdemo\ 1.0\" 
-DPACKAGE_BUGREPORT=\"address@hidden" -DPACKAGE=\"mdemo\" -DVERSION=\"1.0\" 
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" 
-DHAVE_MATH_H=1  -I. -I/tmp/libtool/tests/mdemo  
-I/tmp/libtool/tests/mdemo/../..    -g -O2 -c /tmp/libtool/tests/mdemo/main.c
| /bin/sh ./libtool --mode=link --tag=CC gcc  -g -O2   -o mdemo -export-dynamic 
main.o ./../../libltdl/libltdlc.la libsub.la "-dlopen" self "-dlopen" foo1.la 
"-dlopen" libfoo2.la
| libtool: link: rm -f .libs/mdemo.nm .libs/mdemo.nmS .libs/mdemo.nmT
| libtool: link: creating .libs/mdemoS.c
| libtool: link: generating symbol list for `mdemo'
| libtool: link: extracting global C symbols from `main.o'
| libtool: link: (cd .libs && gcc -g -O2 -c -fno-builtin "mdemoS.c")
| libtool: link: rm -f ".libs/mdemoS.c" ".libs/mdemo.nm" ".libs/mdemo.nmS" 
".libs/mdemo.nmT"
| libtool: link: gcc -g -O2 -o .libs/mdemo main.o .libs/mdemoS.o 
-Wl,--export-dynamic  /tmp/build/libltdl/.libs/dlopen.a 
./../../libltdl/.libs/libltdlc.a -ldl ./.libs/libsub.so -Wl,-rpath 
-Wl,/tmp/build/_inst/lib
| main.o(.text+0x420): In function `main':
| /tmp/libtool/tests/mdemo/main.c:180: undefined reference to 
`lt_preloaded_symbols'
| collect2: ld returned 1 exit status
| make: *** [mdemo] Error 1

To reproduce, I guess all you'll have to do is uninstall any ltdl.h from
CVS HEAD.

I suggest reverting your change and applying my suggested, pretty
trivial patch, instead.  Do you agree?

Cheers,
Ralf