Re: [patch 07/19] 291-gary-centralise-INCLTDL.diff Queue

[Ralf Wildenhues]

Hi Gary,

* Gary V. Vaughan wrote on Fri, Oct 14, 2005 at 05:38:38PM CEST:
> Redone to fix the problems you encountered in the other thread
> about this patch.  Okay to commit?

Erm, no?  This patch is completely identical to the one I reverted.
Unless I missed something very badly, LT_WITH_LTDL is still not
required (and I would likely reject a patch that changes this),
and as such, the synching does not necessarily happen.

Gary, "fixing" this seems really low-importance to me, even if there
was a trivial fix available.  The current code does not show a bug,
it's just a bit ugly because repetitive.  Other stuff is much more
important.

Cheers,
Ralf, now off to the other stuff..

>  libltdl/m4/ltdl.m4 |   19 +++++--------------
>  1 files changed, 5 insertions(+), 14 deletions(-)
> 
> Index: libtool--devo--1.0/ChangeLog
> from  Gary V. Vaughan  <address@hidden>
>         * libltdl/m4/ltdl.m4 (LTDL_CONVENIENCE, LTDL_INSTALLABLE): Remove
>         AC_SUBST of LIBLTDL, LTDLINCL, and all mention of INCLTDL.
>         (LT_WITH_LTDL): Due to order constraints between LTDL_CONVENIENCE,
>         LTDL_INSTALLABLE, LT_WITH_LTDL & LTDL_INIT, we can safely AC_SUBST
>         LIBLTDL and LTDLINCL here.  Also, remember to synch INCLTDL.
> 
> Index: libtool--devo--1.0/libltdl/m4/ltdl.m4
> ===================================================================
> --- libtool--devo--1.0.orig/libltdl/m4/ltdl.m4
> +++ libtool--devo--1.0/libltdl/m4/ltdl.m4
> @@ -69,13 +69,6 @@ case $enable_ltdl_convenience in
>    esac
>  LIBLTDL='${top_builddir}'"${lt_ltdl_dir+/$lt_ltdl_dir}/libltdlc.la"
>  LTDLINCL='-I${top_srcdir}'"${lt_ltdl_dir+/$lt_ltdl_dir}"
> -
> -AC_SUBST([LIBLTDL])
> -AC_SUBST([LTDLINCL])
> -
> -# For backwards non-gettext consistent compatibility...
> -INCLTDL="$LTDLINCL"
> -AC_SUBST([INCLTDL])
>  ])# LTDL_CONVENIENCE
> 
>  # AC_LIBLTDL_CONVENIENCE accepted a directory argument in older libtools,
> @@ -125,13 +118,6 @@ else
>    LIBLTDL="-lltdl"
>    LTDLINCL=
>  fi
> -
> -AC_SUBST([LIBLTDL])
> -AC_SUBST([LTDLINCL])
> -
> -# For backwards non-gettext consistent compatibility...
> -INCLTDL="$LTDLINCL"
> -AC_SUBST([INCLTDL])
>  ])# LTDL_INSTALLABLE
> 
>  # AC_LIBLTDL_INSTALLABLE accepted a directory argument in older libtools,
> @@ -223,6 +209,11 @@ m4_if(_LTDL_MODE, [subproject],
>             [],
>         [LTDL_INIT
>         AC_DEFUN([LTDL_INIT], [])])])
> +
> +AC_SUBST([LIBLTDL])
> +AC_SUBST([LTDLINCL])
> +dnl For backwards non-gettext consistent compatibility...
> +AC_SUBST([INCLTDL], ["$LTDLINCL"])
>  ])# LT_WITH_LTDL
> 
>  # Old name: