[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

If -xarch passed in, don't set compiler_flags _only_ for GCC

From: Albert Chin
Subject: If -xarch passed in, don't set compiler_flags _only_ for GCC
Date: Mon, 17 Oct 2005 16:07:04 -0500
User-agent: Mutt/1.5.6i

HEAD sets compiler_flags in the code below regardless of whether or
not GCC is the compiler. Why does branch-1-5 do it differently? If
someone is building a 64-bit library with the Sun C++ compiler,
-xarch=v9 won't get passed through and ld will try to create a 32-bit
library, resulting in an error.

2005-10-17  Albert Chin-A-Young  <address@hidden>

        * When accepting -64, -mips[0-9], et. al. compiler
        flags, don't set compiler_flags only for GCC as the vendor
        compiler also requires this flag. Sync with HEAD.
        Reported by Donald Anderson <address@hidden>.

albert chin (address@hidden)

-- snip snip
RCS file: /cvsroot/libtool/libtool/Attic/,v
retrieving revision 1.334.2.90
diff -u -3 -p -r1.334.2.90
---   17 Oct 2005 14:06:26 -0000      1.334.2.90
+++   17 Oct 2005 20:57:59 -0000
@@ -1550,9 +1550,7 @@ EOF
         compile_command="$compile_command $arg"
         finalize_command="$finalize_command $arg"
-        if test "$with_gcc" = "yes" ; then
-          compiler_flags="$compiler_flags $arg"
-        fi
+        compiler_flags="$compiler_flags $arg"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]