Re: whole_archive_flag_spec and reload_cmds (PGI)

[Ralf Wildenhues]

* Ralf Wildenhues wrote on Fri, Feb 10, 2006 at 05:37:09PM CET:
> PGI compilers are currently the only ones for which libtool uses
> comma-separated archives in whole_archive_flag_spec currently.  The
> hack below makes them work for reload_cmds, too, where we use $LD
> directly.  Exposed by duplicate_conv.test.  :)
> 
> OK to apply this patch (HEAD and branch-1-5)?

Applied.  The branch-1-5 patch shown below.

Cheers,
Ralf

        * ltmain.in (link mode) [ linux ]: PGI: for `reload_cmds', we
        not only need to get rid of `$wl', but also turn comma into
        space so $LD understands whole_archive_flag_spec correctly.

Index: ltmain.in
===================================================================
RCS file: /cvsroot/libtool/libtool/Attic/ltmain.in,v
retrieving revision 1.334.2.122
diff -u -r1.334.2.122 ltmain.in
--- ltmain.in   13 Feb 2006 16:52:38 -0000      1.334.2.122
+++ ltmain.in   13 Feb 2006 17:01:42 -0000
@@ -4265,12 +4265,14 @@
       reload_conv_objs=
       gentop=
       # reload_cmds runs $LD directly, so let us get rid of
-      # -Wl from whole_archive_flag_spec
+      # -Wl from whole_archive_flag_spec and hope we can get by with
+      # turning comma into space..
       wl=
 
       if test -n "$convenience"; then
        if test -n "$whole_archive_flag_spec"; then
-         eval reload_conv_objs=\"\$reload_objs $whole_archive_flag_spec\"
+         eval tmp_whole_archive_flags=\"$whole_archive_flag_spec\"
+         reload_conv_objs=$reload_objs\ `$echo "X$tmp_whole_archive_flags" | 
$Xsed -e 's|,| |g'`
        else
          gentop="$output_objdir/${obj}x"
          generated="$generated $gentop"