[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 317-gary-simplify-verbatim-shell-quoting.diff
From: |
Ralf Wildenhues |
Subject: |
Re: 317-gary-simplify-verbatim-shell-quoting.diff |
Date: |
Mon, 5 Mar 2007 18:51:03 +0100 |
User-agent: |
Mutt/1.5.14 (2007-02-28) |
Hello Gary,
* Gary V. Vaughan wrote on Mon, Mar 05, 2007 at 11:46:59AM CET:
>
> The vast majority of this patch is the removal of extraneous m4
> quotes enabled by adding and using the M4SH_VERBATIM macro to
> general.m4sh.
>
> Okay to commit?
Please fix the bugs below, manually remove (so that inadvertently not
using Makefile.maint won't skew your observations) and regenerate all
files involved (libtool, libtoolize, tests/defs, $srcdir/commit, and
$srcdir/libltdl/config/mailnotify) and check that there are only
whitespace differences against the version without the patch, add some
blurb about M4SH_VERBATIM to HACKING, and apply. Thank you.
Cheers,
Ralf
$ diff libtool-before libtool-after
498a499,500
>
>
813a816,818
>
>
>
874a880,882
>
>
>
2191c2199
< && $ECHO "X$libobj" | $GREP '[]~#^*{};<>?"'"'"' &()|`$[]' \
---
> && $ECHO "X$libobj" | $GREP ['[]~#^*{};<>?"'"'"' &()|`$[]'] \
7135c7143
< # Zsh 3.x and 4.x performs word splitting on \${1+\"address@hidden"}, which
---
> [#] Zsh 3.x and 4.x performs word splitting on \${1+\"address@hidden"},
> which
7137c7145
< alias -g '\${1+\"address@hidden"}'='\"address@hidden"'
---
> alias -g '\${1+\"address@hidden"}'='\"address@hidden"'
7824a7833,7834
>
>
$ diff libtoolize-before libtoolize-after
244a245,246
>
>
559a562,564
>
>
>
620a626,628
>
>
>
1450c1458
< func_echo "Consider adding \`AC_CONFIG_MACRO_DIR(m4)' to $configure_ac
and rerunning"
---
> func_echo "Consider adding \`AC_CONFIG_MACRO_DIR([m4])' to
> $configure_ac and rerunning"
1453c1461
< func_echo "Consider adding \`AC_CONFIG_MACRO_DIR($m4dir)'to
$configure.ac,"
---
> func_echo "Consider adding \`AC_CONFIG_MACRO_DIR([$m4dir])'to
> $configure.ac,"
1733a1742
>