[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 319-gary-refactor-m4sh-rules
From: |
Ralf Wildenhues |
Subject: |
Re: 319-gary-refactor-m4sh-rules |
Date: |
Tue, 6 Mar 2007 23:23:12 +0100 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Hello Gary,
* Gary V. Vaughan wrote on Tue, Mar 06, 2007 at 08:33:50PM CET:
>
> This makes code sharing with forthcoming func_version test cases easier.
>
> Okay to commit?
IMHO this is definitely post 2.0: it doesn't fix an important bug.
Moreover it's wrong, too: the $(srcdir) are there for a reason.
Sorry.
If you're out to relax the requirement for GNU make, then I suggest
you give some information as to which make implementations you have
successfully tested with.
Cheers,
Ralf
> Index: ChangeLog
> from Gary V. Vaughan <address@hidden>
> Factorize make rules used for m4sh sources:
>
> * Makefile.am (EXTRA_DIST, libtoolize, libtool): No need to
> explicitly name $(srcdir) in dependencies, VPATH will look there
> automatically.
> (SUFFIXES, .m4sh.in, .m4sh.sh): New suffix rules...
> ($(srcdir)/tests/defs, $(srcdir)/$(auxdir)/ltmain.sh): ...factored
> out from here...
> ($(srcdir)/tests/defs.in): ...and here.
> * Makefile.maint (.SUFFIXES): Add explicitly for bootstrap, as
> bootstrap's quick-n-dirty Makefile doesn't have the correct
> syntax.
> (.in.tmp): New suffix rule...
> ($(srcdir)/commit, $(srcdir)/mailnotify): ...factored out from
> here.