[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 329-gary-allow-RTLD_GLOBAL

From: Bob Friesenhahn
Subject: Re: 329-gary-allow-RTLD_GLOBAL
Date: Tue, 10 Apr 2007 09:35:45 -0500 (CDT)

On Tue, 10 Apr 2007, Gary V. Vaughan wrote:

 int errors = 0;
 lt_dlhandle handle;
 lt_dladvise advise = lt_dladvise_init ();

 if (advise == 0)
   return 1;

Not ideal. By comparing with zero there is an implicit assumption regarding the lt_dladvise type. It is usually better to avoid any user knowledge of the type:

  lt_dladvise advise;
  if (!lt_dladvise_init(&advise))
     return 1;

In this way, lt_dladvise can be a pointer, an integer, or a structure.

Bob Friesenhahn
GraphicsMagick Maintainer,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]